Skip to content

Conversation

@vsriramv
Copy link
Contributor

@vsriramv vsriramv commented Jan 11, 2026

This adds a UI test to associated-const-bindings (created new) directory to ensure that constant projections with associated const equality bounds are correctly normalized.

File added:

  • tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs

r? @fmease
r? @camelid

Fixes #120905

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

fmease is not on the review rotation at the moment.
They may take a while to respond.

Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-log-analyzer

This comment has been minimized.

@fmease
Copy link
Member

fmease commented Jan 11, 2026

In PR #150843, I've created a new test subdirectory specifically for associated const equality aka associated const bindings, namely tests/ui/const-generics/associated-const-bindings/. Well, the change hasn't been merged yet but it's in the merge queue (see PR #150843).

Could you move that test into this directory (which you have to create first since it doesn't exist on main yet). I hope that that won't lead to merge conflicts down the line but it really shouldn't.

@fmease
Copy link
Member

fmease commented Jan 11, 2026

Could you please also squash your changes into one commit? Thanks!

@vsriramv
Copy link
Contributor Author

ok, sure!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move+rename this file to tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs? Thanks in advance!

See #150975 (comment) for context.

Copy link
Contributor Author

@vsriramv vsriramv Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@rust-log-analyzer

This comment has been minimized.

@vsriramv vsriramv force-pushed the add-test-norm-const-projections-mgca branch from 4f26b69 to 8d1d88b Compare January 11, 2026 18:40
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@fmease
Copy link
Member

fmease commented Jan 11, 2026

@bors r+ rollup

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

📌 Commit 8d1d88b has been approved by fmease

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2026
rust-bors bot added a commit that referenced this pull request Jan 12, 2026
Rollup of 9 pull requests

Successful merges:

 - #147938 (Add const cloning of slices and tests)
 - #149718 (Add freeze file times on Windows)
 - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc)
 - #150790 (feat: invisible character help string)
 - #150906 (Simplify `#[eii]` macro using methods on ecx)
 - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system)
 - #150953 (std: sys: fs: uefi: Implement copy)
 - #150964 (Completely list all unparsed attributes)
 - #150975 (ui: add test for normalizing const projections with assoc const equality)

Failed merges:

 - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items))

r? @ghost
@rust-bors rust-bors bot merged commit c31e68f into rust-lang:main Jan 12, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 12, 2026
Rollup merge of #150975 - add-test-norm-const-projections-mgca, r=fmease

ui: add test for normalizing const projections with assoc const equality

This adds a UI test to associated-const-bindings (created new) directory to  ensure that constant projections with associated const equality bounds are correctly normalized.

File added:
- `tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs`

r? @fmease
r? @camelid

Fixes #120905
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mgca: Add test for normalizing const projections with assoc const equality bounds

4 participants