-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
ui: add test for normalizing const projections with assoc const equality #150975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add test for normalizing const projections with assoc const equality #150975
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tests/ui/const-generics/mgca/assoc-const-equality-normalization.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
In PR #150843, I've created a new test subdirectory specifically for associated const equality aka associated const bindings, namely Could you move that test into this directory (which you have to create first since it doesn't exist on main yet). I hope that that won't lead to merge conflicts down the line but it really shouldn't. |
|
Could you please also squash your changes into one commit? Thanks! |
|
ok, sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move+rename this file to tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs? Thanks in advance!
See #150975 (comment) for context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
This comment has been minimized.
This comment has been minimized.
4f26b69 to
8d1d88b
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ rollup |
Rollup of 9 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150790 (feat: invisible character help string) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) - #150975 (ui: add test for normalizing const projections with assoc const equality) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
Rollup merge of #150975 - add-test-norm-const-projections-mgca, r=fmease ui: add test for normalizing const projections with assoc const equality This adds a UI test to associated-const-bindings (created new) directory to ensure that constant projections with associated const equality bounds are correctly normalized. File added: - `tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rs` r? @fmease r? @camelid Fixes #120905
This adds a UI test to associated-const-bindings (created new) directory to ensure that constant projections with associated const equality bounds are correctly normalized.
File added:
tests/ui/const-generics/associated-const-bindings/normalization-via-param-env.rsr? @fmease
r? @camelid
Fixes #120905